ekzyis
/
stacker.news
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More concise PR template (#1092) 

The big HTML comments were getting in the way.
This commit is contained in:
ekzyis 2024-04-19 17:56:08 +02:00 committed by GitHub
parent 9e6675b8d2
commit 0552736dc7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
.github/pull_request_template.md vendored
View File

@ -1,58 +1,37 @@
## Description ## Description
<!-- <!--
A clear and concise description of what you changed and why. A clear and concise description of what you changed and why.
Bullet points can be enough.
You can use the following PRs as inspiration:
- https://github.com/stackernews/stacker.news/pull/227 (feature)
- https://github.com/stackernews/stacker.news/pull/915 (feature)
- https://github.com/stackernews/stacker.news/pull/871 (fix)
- <your PR could be here>
Don't forget to mention which tickets this closes (if any). Don't forget to mention which tickets this closes (if any).
Use following syntax to close them automatically on merge: closes #<NUMBER> Use following syntax to close them automatically on merge: closes #<number>
--> -->
## Screenshots ## Screenshots
<!-- <!--
If your changes are user facing, please add screenshots of the new UI. If your changes are user facing, please add screenshots of the new UI.
You can also create a video to showcase your changes (useful to show UX). You can also create a video to showcase your changes (useful to show UX).
--> -->
## Additional Context ## Additional Context
<!-- <!--
You can mention here anything that you think is relevant for this PR. Some examples: You can mention here anything that you think is relevant for this PR. Some examples:
* You encountered something that you didn't understand while working on this PR * You encountered something that you didn't understand while working on this PR
* You were not sure about something you did but did not find a better way * You were not sure about something you did but did not find a better way
* You initially had a different approach but went with a different approach for some reason * You initially had a different approach but went with a different approach for some reason
--> -->
## Checklist ## Checklist
<!-- Examples for backwards incompatible changes:
- dropping database columns
- changing GraphQL type definitions to make a field mandatory -->
- [ ] Are your changes backwards compatible? - [ ] Are your changes backwards compatible?
<!-- If your PR is not ready for review yet, please mark your PR as a draft. <!--
If changes were requested, request a new review when you incorporated the feedback. --> If your PR is not ready for review yet, please mark your PR as a draft.
If changes were requested, request a new review when you incorporated the feedback.
-->
- [ ] Did you QA this? Could we deploy this straight to production? - [ ] Did you QA this? Could we deploy this straight to production?
<!-- You should be able to use the mobile browser emulator in your browser to test this. -->
- [ ] For frontend changes: Tested on mobile? - [ ] For frontend changes: Tested on mobile?
<!-- New env vars need to be called out
so they can be properly configured for prod. -->
- [ ] Did you introduce any new environment variables? If so, call them out explicitly in the PR description. - [ ] Did you introduce any new environment variables? If so, call them out explicitly in the PR description.