From 1c608d42f41cb8932bcec6ce8576c62b84b69ae7 Mon Sep 17 00:00:00 2001
From: keyan <keyan.kousha+huumn@gmail.com>
Date: Sat, 6 May 2023 18:53:10 -0500
Subject: [PATCH] denormalize votes

---
 api/resolvers/item.js                         | 10 +----
 .../migration.sql                             |  2 +
 .../migration.sql                             | 42 +++++++++++++++++++
 prisma/schema.prisma                          |  3 +-
 4 files changed, 47 insertions(+), 10 deletions(-)
 create mode 100644 prisma/migrations/20230506232839_higher_tip_default/migration.sql
 create mode 100644 prisma/migrations/20230506233136_denorm_upvotes/migration.sql

diff --git a/api/resolvers/item.js b/api/resolvers/item.js
index d3e9d1b9..10b3b927 100644
--- a/api/resolvers/item.js
+++ b/api/resolvers/item.js
@@ -904,14 +904,6 @@ export default {
       }
       return comments(me, models, item.id, item.pinId ? 'recent' : 'hot', item)
     },
-    upvotes: async (item, args, { models }) => {
-      const [{ count }] = await models.$queryRaw(`
-        SELECT COUNT(DISTINCT "userId") as count
-        FROM "ItemAct"
-        WHERE act = 'TIP' AND "itemId" = $1`, Number(item.id))
-
-      return count
-    },
     wvotes: async (item) => {
       return item.weightedVotes - item.weightedDownVotes
     },
@@ -1123,7 +1115,7 @@ const createItem = async (parent, { sub, title, url, text, boost, forward, bount
 export const SELECT =
   `SELECT "Item".id, "Item".created_at as "createdAt", "Item".updated_at as "updatedAt", "Item".title,
   "Item".text, "Item".url, "Item"."bounty", "Item"."userId", "Item"."fwdUserId", "Item"."parentId",
-  "Item"."pinId", "Item"."maxBid", "Item"."rootId",
+  "Item"."pinId", "Item"."maxBid", "Item"."rootId", "Item".upvotes,
   "Item".company, "Item".location, "Item".remote, "Item"."deletedAt",
   "Item"."subName", "Item".status, "Item"."uploadId", "Item"."pollCost", "Item".boost,
   "Item".msats, "Item".ncomments, "Item"."commentMsats", "Item"."lastCommentAt", "Item"."weightedVotes",
diff --git a/prisma/migrations/20230506232839_higher_tip_default/migration.sql b/prisma/migrations/20230506232839_higher_tip_default/migration.sql
new file mode 100644
index 00000000..0a6e7241
--- /dev/null
+++ b/prisma/migrations/20230506232839_higher_tip_default/migration.sql
@@ -0,0 +1,2 @@
+-- AlterTable
+ALTER TABLE "users" ALTER COLUMN "tipDefault" SET DEFAULT 100;
diff --git a/prisma/migrations/20230506233136_denorm_upvotes/migration.sql b/prisma/migrations/20230506233136_denorm_upvotes/migration.sql
new file mode 100644
index 00000000..30bab2ea
--- /dev/null
+++ b/prisma/migrations/20230506233136_denorm_upvotes/migration.sql
@@ -0,0 +1,42 @@
+-- AlterTable
+ALTER TABLE "Item" ADD COLUMN "upvotes" INTEGER NOT NULL DEFAULT 0;
+
+UPDATE "Item"
+SET upvotes = subquery.votes
+FROM (SELECT "ItemAct"."itemId", COUNT(DISTINCT "userId") AS votes
+        FROM "ItemAct"
+        WHERE "ItemAct".act = 'TIP'
+        GROUP BY "ItemAct"."itemId") subquery
+WHERE "Item".id = subquery."itemId";
+
+CREATE OR REPLACE FUNCTION weighted_votes_after_tip(item_id INTEGER, user_id INTEGER, sats INTEGER) RETURNS INTEGER AS $$
+DECLARE
+    user_trust DOUBLE PRECISION;
+    sats_past INTEGER;
+    vote_add INTEGER := 0;
+    multiplier DOUBLE PRECISION;
+BEGIN
+    -- grab user's trust who is upvoting
+    SELECT trust INTO user_trust FROM users WHERE id = user_id;
+
+    -- in order to add this to weightedVotes, we need to do log((satsN+satsPrior)/satsPrior)
+    -- so compute sats prior
+    SELECT SUM(msats) / 1000 INTO sats_past
+    FROM "ItemAct"
+    WHERE "userId" = user_id AND "itemId" = item_id AND act IN ('TIP', 'FEE');
+
+    IF sats_past IS NULL OR sats_past = 0 THEN
+        multiplier := LOG(sats);
+        vote_add := 1;
+    ELSE
+        multiplier := LOG((sats+sats_past)/sats_past::FLOAT);
+    END IF;
+
+    -- update item
+    UPDATE "Item"
+        SET "weightedVotes" = "weightedVotes" + (user_trust * multiplier), upvotes = upvotes + vote_add
+        WHERE id = item_id AND "userId" <> user_id;
+
+    RETURN 0;
+END;
+$$ LANGUAGE plpgsql;
\ No newline at end of file
diff --git a/prisma/schema.prisma b/prisma/schema.prisma
index 2e40860b..38b64a4a 100644
--- a/prisma/schema.prisma
+++ b/prisma/schema.prisma
@@ -252,7 +252,6 @@ model Item {
   path        Unsupported("LTREE")?
   pin         Pin?                  @relation(fields: [pinId], references: [id])
   pinId       Int?
-  boost       Int                   @default(0)
   uploadId    Int?
   upload      Upload?
   paidImgLink Boolean               @default(false)
@@ -273,6 +272,8 @@ model Item {
   weightedVotes     Float  @default(0)
   weightedDownVotes Float  @default(0)
   msats             BigInt @default(0)
+  boost             Int    @default(0)
+  upvotes           Int    @default(0)
 
   // denormalized comment stats
   ncomments     Int       @default(0)