Fix push notifications sent without thread subscription (#2118)

* Fix push notifications sent without thread subscription * Remove duplicate ancestor check
2025-04-21 23:00:21 +02:00 · 2025-04-21 23:00:21 +02:00 · 4c2f059fb5
commit 4c2f059fb5
parent ff057039f5
1 changed files with 4 additions and 0 deletions
--- a/lib/webPush.js
+++ b/lib/webPush.js
@ -256,6 +256,10 @@ export const notifyItemParents = async ({ models, item }) => {
      AND NOT EXISTS (
        SELECT 1 FROM "Mute" m
        WHERE m."muterId" = p."userId" AND m."mutedId" = ${Number(user.id)}
+      )
+      AND EXISTS (
+        -- check that there is at least one parent subscribed to this thread
+        SELECT 1 FROM "ThreadSubscription" ts WHERE p.id = ts."itemId"
      )`
    await Promise.allSettled(
      parents.map(({ userId, isDirect }) => {