Merge pull request #1825 from Soxasora/fix_sw_uncaught_promise

fix: uncaught promise on getOS causes onMessage event to end early
This commit is contained in:
Keyan 2025-01-18 11:43:17 -06:00 committed by GitHub
commit 566a5f9675
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions

View File

@ -236,7 +236,7 @@ export function onMessage (sw) {
messageChannelPort = event.ports[0]
}
log('[sw:message] received message', 'info', { action: event.data.action })
const currentOS = await getOS()
const currentOS = event.waitUntil(getOS())
log('[sw:message] stored os: ' + currentOS, 'info', { action: event.data.action })
if (event.data.action === STORE_SUBSCRIPTION) {
log('[sw:message] storing subscription in IndexedDB', 'info', { endpoint: event.data.subscription.endpoint })
@ -253,8 +253,8 @@ export function onMessage (sw) {
promises.push(sw.registration.getNotifications().then((notifications) => {
notifications.forEach(notification => notification.close())
}))
activeCount = 0
promises.push(clearAppBadge(sw))
activeCount = 0
event.waitUntil(Promise.all(promises))
}
}