don't toast on invoice cancellation

components/item-act.js

@@ -8,7 +8,6 @@ import { amountSchema } from '@/lib/validate'
 import { useToast } from './toast'
 import { useLightning } from './lightning'
 import { nextTip } from './upvote'
-import { InvoiceCanceledError } from './payment'
 import { ZAP_UNDO_DELAY_MS } from '@/lib/constants'
 import { usePaidMutation } from './use-paid-mutation'
 import { ACT_MUTATION } from '@/fragments/paidAction'
@@ -72,7 +71,7 @@ export default function ItemAct ({ onClose, item, down, children, abortSignal })
         }
       }
     }
-    await act({
+    const { error } = await act({
       variables: {
         id: item.id,
         sats: Number(amount),
@@ -95,6 +94,7 @@ export default function ItemAct ({ onClose, item, down, children, abortSignal })
         if (!me) setItemMeAnonSats({ id: item.id, amount })
       }
     })
+    if (error) throw error
     addCustomTip(Number(amount))
   }, [me, act, down, item.id, onClose, abortSignal, strike])
 
@@ -219,15 +219,15 @@ export function useZap () {
     try {
       await abortSignal.pause({ me, amount: sats })
       strike()
-      await act({ variables, optimisticResponse })
+      const { error } = await act({ variables, optimisticResponse })
+      if (error) throw error
     } catch (error) {
-      if (error instanceof InvoiceCanceledError || error instanceof ActCanceledError) {
+      if (error instanceof ActCanceledError) {
         return
       }
 
       const reason = error?.message || error?.toString?.()
-
-      toaster.danger('zap failed: ' + reason)
+      toaster.danger(reason)
     }
   }, [me?.id, strike])
 }

components/item-info.js

@@ -24,6 +24,7 @@ import { MuteSubDropdownItem, PinSubDropdownItem } from './territory-header'
 import UserPopover from './user-popover'
 import { useQrPayment } from './payment'
 import { useRetryCreateItem } from './use-item-submit'
+import { useToast } from './toast'
 
 export default function ItemInfo ({
   item, full, commentsText = 'comments',
@@ -32,6 +33,7 @@ export default function ItemInfo ({
 }) {
   const editThreshold = new Date(item.invoice?.confirmedAt ?? item.createdAt).getTime() + 10 * 60000
   const me = useMe()
+  const toaster = useToast()
   const router = useRouter()
   const [canEdit, setCanEdit] =
     useState(item.mine && (Date.now() < editThreshold))
@@ -72,7 +74,14 @@ export default function ItemInfo ({
     if (me && item.invoice?.actionState && item.invoice?.actionState !== 'PAID') {
       if (item.invoice?.actionState === 'FAILED') {
         Component = () => <span className='text-warning'>retry payment</span>
-        onClick = async () => await retryCreateItem({ variables: { invoiceId: parseInt(item.invoice?.id) } }).catch(console.error)
+        onClick = async () => {
+          try {
+            const { error } = await retryCreateItem({ variables: { invoiceId: parseInt(item.invoice?.id) } })
+            if (error) throw error
+          } catch (error) {
+            toaster.danger(error.message)
+          }
+        }
       } else {
         Component = () => (
           <span

components/notifications.js

@@ -36,6 +36,7 @@ import { usePollVote } from './poll'
 import { paidActionCacheMods } from './use-paid-mutation'
 import { useRetryCreateItem } from './use-item-submit'
 import { payBountyCacheMods } from './pay-bounty'
+import { useToast } from './toast'
 
 function Notification ({ n, fresh }) {
   const type = n.__typename
@@ -334,6 +335,7 @@ function useActRetry ({ invoice }) {
 }
 
 function Invoicification ({ n: { invoice, sortTime } }) {
+  const toaster = useToast()
   const actRetry = useActRetry({ invoice })
   const retryCreateItem = useRetryCreateItem({ id: invoice.item?.id })
   const retryPollVote = usePollVote({ query: RETRY_PAID_ACTION, itemId: invoice.item?.id })
@@ -390,8 +392,13 @@ function Invoicification ({ n: { invoice, sortTime } }) {
           <Button
             size='sm' variant='outline-warning ms-2 border-1 rounded py-0'
             style={{ '--bs-btn-hover-color': '#fff', '--bs-btn-active-color': '#fff' }}
-            onClick={() => {
-              retry({ variables: { invoiceId: parseInt(invoiceId) } }).catch(console.error)
+            onClick={async () => {
+              try {
+                const { error } = await retry({ variables: { invoiceId: parseInt(invoiceId) } })
+                if (error) throw error
+              } catch (error) {
+                toaster.danger(error?.message || error?.toString?.())
+              }
             }}
           >
             retry

components/pay-bounty.js

@@ -7,7 +7,6 @@ import { numWithUnits } from '@/lib/format'
 import { useShowModal } from './modal'
 import { useRoot } from './root'
 import { ActCanceledError, useAct } from './item-act'
-import { InvoiceCanceledError } from './payment'
 import { useLightning } from './lightning'
 import { useToast } from './toast'
 
@@ -58,15 +57,15 @@ export default function PayBounty ({ children, item }) {
   const handlePayBounty = async onCompleted => {
     try {
       strike()
-      await act({ onCompleted })
+      const { error } = await act({ onCompleted })
+      if (error) throw error
     } catch (error) {
-      if (error instanceof InvoiceCanceledError || error instanceof ActCanceledError) {
+      if (error instanceof ActCanceledError) {
         return
       }
 
       const reason = error?.message || error?.toString?.()
-
-      toaster.danger('pay bounty failed: ' + reason)
+      toaster.danger(reason)
     }
   }
 

components/payment.js

@@ -13,6 +13,7 @@ export class InvoiceCanceledError extends Error {
     super(actionError ?? `invoice canceled: ${hash}`)
     this.name = 'InvoiceCanceledError'
     this.hash = hash
+    this.actionError = actionError
   }
 }
 

components/poll.js

@@ -5,7 +5,7 @@ import { useMe } from './me'
 import styles from './poll.module.css'
 import { signIn } from 'next-auth/react'
 import ActionTooltip from './action-tooltip'
-import { InvoiceCanceledError, useQrPayment } from './payment'
+import { useQrPayment } from './payment'
 import { useToast } from './toast'
 import { usePaidMutation } from './use-paid-mutation'
 import { POLL_VOTE, RETRY_PAID_ACTION } from '@/fragments/paidAction'
@@ -25,18 +25,14 @@ export default function Poll ({ item }) {
               const variables = { id: v.id }
               const optimisticResponse = { pollVote: { __typename: 'PollVotePaidAction', result: { id: v.id } } }
               try {
-                await pollVote({
+                const { error } = await pollVote({
                   variables,
                   optimisticResponse
                 })
+                if (error) throw error
               } catch (error) {
-                if (error instanceof InvoiceCanceledError) {
-                  return
-                }
-
                 const reason = error?.message || error?.toString?.()
-
-                toaster.danger('poll vote failed: ' + reason)
+                toaster.danger(reason)
               }
             }
             : signIn}

components/territory-form.js

@@ -41,7 +41,7 @@ export default function TerritoryForm ({ sub }) {
         : await upsertSub({ variables: { oldName: sub?.name, ...variables } })
 
       if (error) throw error
-      if (payError) throw new Error('payment required')
+      if (payError) return
 
       // modify graphql cache to include new sub
       client.cache.modify({

components/territory-payment-due.js

@@ -16,15 +16,13 @@ export default function TerritoryPaymentDue ({ sub }) {
   const client = useApolloClient()
   const [paySub] = usePaidMutation(SUB_PAY)
 
-  const onSubmit = useCallback(
-    async ({ ...variables }) => {
-      const { error, payError } = await paySub({
-        variables
-      })
+  const onSubmit = useCallback(async ({ ...variables }) => {
+    const { error } = await paySub({
+      variables
+    })
 
-      if (error) throw error
-      if (payError) throw new Error('payment required')
-    }, [client, paySub])
+    if (error) throw error
+  }, [client, paySub])
 
   if (!sub || sub.userId !== Number(me?.id) || sub.status === 'ACTIVE') return null
 

components/use-item-submit.js

@@ -59,7 +59,7 @@ export default function useItemSubmit (mutation,
       })
 
       if (error) throw error
-      if (payError) throw new Error('payment required')
+      if (payError) return
 
       // we don't know the mutation name, so we have to extract the result
       const response = Object.values(data)[0]

components/use-paid-mutation.js

@@ -63,6 +63,14 @@ export function usePaidMutation (mutation,
 
     // if the mutation returns an invoice, pay it
     if (invoice) {
+      // adds payError, escalating to a normal error if the invoice is not canceled or
+      // has an actionError
+      const addPayError = (e, rest) => ({
+        ...rest,
+        payError: e,
+        error: e instanceof InvoiceCanceledError && e.actionError ? e : undefined
+      })
+
       // should we wait for the invoice to be paid?
       if (response?.paymentMethod === 'OPTIMISTIC' && !forceWaitForPayment) {
         // onCompleted is called before the invoice is paid for optimistic updates
@@ -75,7 +83,7 @@ export function usePaidMutation (mutation,
           // onPayError is called after the invoice fails to pay
           // useful for updating invoiceActionState to FAILED
           onPayError?.(e, client.cache, { data })
-          setInnerResult(r => ({ payError: e, ...r }))
+          setInnerResult(r => addPayError(e, r))
         })
       } else {
         // the action is pessimistic
@@ -95,7 +103,7 @@ export function usePaidMutation (mutation,
         } catch (e) {
           console.error('usePaidMutation: failed to pay invoice', e)
           onPayError?.(e, client.cache, { data })
-          rest = { ...rest, payError: e, error: e }
+          rest = addPayError(e, rest)
         }
       }
     } else {