Use wallets instead of wallets.length as useZap dependency (#2088)

* Potential fix for stale useZap wallet dependency

* Memoize context value for wallets

components/item-act.js

@@ -327,7 +327,7 @@ export function useZap () {
       // but right now this toast is noisy for optimistic zaps
       console.error(error)
     }
-  }, [act, toaster, strike, wallets.length])
+  }, [act, toaster, strike, wallets])
 }
 
 export class ActCanceledError extends Error {

wallets/index.js

@@ -196,17 +196,16 @@ export function WalletsProvider ({ children }) {
 
   // provides priority sorted wallets to children, a function to reload local wallets,
   // and a function to set priorities
+  const value = useMemo(() => ({
+    wallets,
+    reloadLocalWallets,
+    setPriorities,
+    onVaultKeySet: syncLocalWallets,
+    beforeDisconnectVault: unsyncLocalWallets,
+    removeLocalWallets
+  }), [wallets, reloadLocalWallets, setPriorities, syncLocalWallets, unsyncLocalWallets, removeLocalWallets])
   return (
-    <WalletsContext.Provider
+    <WalletsContext.Provider value={value}>
-      value={{
-        wallets,
-        reloadLocalWallets,
-        setPriorities,
-        onVaultKeySet: syncLocalWallets,
-        beforeDisconnectVault: unsyncLocalWallets,
-        removeLocalWallets
-      }}
-    >
       <RetryHandler>
         {children}
       </RetryHandler>