From dfe0c4ad231422d7c9783ed85a59e5fc88578544 Mon Sep 17 00:00:00 2001 From: ekzyis Date: Mon, 3 Mar 2025 14:31:10 -0600 Subject: [PATCH] Fix footnotes and overflow (#1940) * Fix missing uncollapse on footnote click * Add comments to variables --- components/text.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/components/text.js b/components/text.js index effca8a8..48a17a3c 100644 --- a/components/text.js +++ b/components/text.js @@ -49,10 +49,13 @@ export function SearchText ({ text }) { // this is one of the slowest components to render export default memo(function Text ({ rel = UNKNOWN_LINK_REL, imgproxyUrls, children, tab, itemId, outlawed, topLevel }) { + // would the text overflow on the current screen size? const [overflowing, setOverflowing] = useState(false) - const router = useRouter() + // should we show the full text? const [show, setShow] = useState(false) const containerRef = useRef(null) + + const router = useRouter() const [mathJaxPlugin, setMathJaxPlugin] = useState(null) // we only need mathjax if there's math content between $$ tags @@ -69,9 +72,9 @@ export default memo(function Text ({ rel = UNKNOWN_LINK_REL, imgproxyUrls, child // if we are navigating to a hash, show the full text useEffect(() => { - setShow(router.asPath.includes('#') && !router.asPath.includes('#itemfn-')) + setShow(router.asPath.includes('#')) const handleRouteChange = (url, { shallow }) => { - setShow(url.includes('#') && !url.includes('#itemfn-')) + setShow(url.includes('#')) } router.events.on('hashChangeStart', handleRouteChange)