Improve error messages on wrong permissions (#2561)

wallets/client/errors.js

@@ -18,6 +18,7 @@ export class InvoiceExpiredError extends Error {
 export class WalletError extends Error {}
 export class WalletPaymentError extends WalletError {}
 export class WalletConfigurationError extends WalletError {}
+export class WalletValidationError extends WalletError {}
 
 export class WalletNotEnabledError extends WalletConfigurationError {
   constructor (name) {
@@ -100,3 +101,10 @@ export class WalletPaymentAggregateError extends WalletPaymentError {
     this.invoice = invoice
   }
 }
+
+export class WalletPermissionsError extends WalletValidationError {
+  constructor (message) {
+    super('wrong permissions: ' + message)
+    this.name = 'WalletPermissionsError'
+  }
+}

wallets/client/protocols/nwc.js

@@ -1,4 +1,5 @@
 import { supportedMethods, nwcTryRun } from '@/wallets/lib/protocols/nwc'
+import { WalletPermissionsError } from '@/wallets/client/errors'
 
 export const name = 'NWC'
 
@@ -10,6 +11,6 @@ export async function sendPayment (bolt11, { url }, { signal }) {
 export async function testSendPayment ({ url }, { signal }) {
   const supported = await supportedMethods(url, { signal })
   if (!supported.includes('pay_invoice')) {
-    throw new Error('pay_invoice not supported')
+    throw new WalletPermissionsError('credentials do not allow spending')
   }
 }

wallets/server/protocols/nwc.js

@@ -1,3 +1,4 @@
+import { WalletPermissionsError } from '@/wallets/client/errors'
 import { nwcTryRun, supportedMethods } from '@/wallets/lib/protocols/nwc'
 
 export const name = 'NWC'
@@ -16,13 +17,13 @@ export async function testCreateInvoice ({ url }, { signal }) {
   const supports = (method) => supported.includes(method)
 
   if (!supports('make_invoice')) {
-    throw new Error('make_invoice not supported')
+    throw new WalletPermissionsError('credentials do not allow receiving')
   }
 
   const mustNotSupport = ['pay_invoice', 'multi_pay_invoice', 'pay_keysend', 'multi_pay_keysend']
   for (const method of mustNotSupport) {
     if (supports(method)) {
-      throw new Error(`${method} must not be supported`)
+      throw new WalletPermissionsError('credentials allow spending')
     }
   }
 

wallets/server/resolvers/protocol.js

@@ -10,6 +10,7 @@ import { notifyNewStreak, notifyStreakLost } from '@/lib/webPush'
 import { decodeCursor, LIMIT, nextCursorEncoded } from '@/lib/cursor'
 import { logContextFromBolt11, walletLogger } from '@/wallets/server/logger'
 import { formatMsats } from '@/lib/format'
+import { WalletValidationError } from '@/wallets/client/errors'
 
 const WalletProtocolConfig = {
   __resolveType: config => config.__resolveType
@@ -87,6 +88,9 @@ export function testWalletProtocol (protocol) {
         WALLET_CREATE_INVOICE_TIMEOUT_MS
       )
     } catch (e) {
+      if (e instanceof WalletValidationError) {
+        throw new GqlInputError(e.message)
+      }
       throw new GqlInputError('failed to create invoice: ' + e.message)
     }