272 Commits

Author SHA1 Message Date
keyan
a17b4d1f1a refine push notification ui and catch promises 2023-07-04 17:19:59 -05:00
ekzyis
388e00dd04
Service worker rework, Web Target Share API & Web Push API (#324)
* npm uninstall next-pwa

next-pwa was last updated in August 2022.
There is also an issue which mentions that next-pwa is abandoned (?): https://github.com/shadowwalker/next-pwa/issues/482

But the main reason for me uninstalling it is that it adds a lot of preconfigured stuff which is not necessary for us.
It even lead to a bug since pages were cached without our knowledge.

So I will go with a different PWA approach. This different approach should do the following:
- make it more transparent what the service worker is doing
- gives us more control to configure the service worker and thus making it easier

* Use workbox-webpack-plugin

Every other plugin (`next-offline`, `next-workbox-webpack-plugin`, `next-with-workbox`, ...) added unnecessary configuration which felt contrary to how PWAs should be built.
(PWAs should progressivly enhance the website in small steps, see https://web.dev/learn/pwa/getting-started/#focus-on-a-feature)

These default configurations even lead to worse UX since they made invalid assumptions about stacker.news:
We _do not_ want to cache our start url and we _do not_ want to cache anything unless explicitly told to.
Almost every page on SN should be fresh for the best UX.

To achieve this, by default, the service worker falls back to the network (as if the service worker wasn't there).

Therefore, this should be the simplest configuration with a valid precache and cache busting support.

In the future, we can try to use prefetching to improve performance of navigation requests.

* Add support for Web Share Target API

See https://developer.chrome.com/articles/web-share-target/

* Use Web Push API for push notifications

I followed this (very good!) guide: https://web.dev/notifications/

* Refactor code related to Web Push

* Send push notification to users on events

* Merge notifications

* Send notification to author of every parent recursively

* Remove unused userId param in savePushSubscription

As it should be, the user id is retrieved from the authenticated user in the backend.

* Resubscribe user if push subscription changed

* Update old subscription if oldEndpoint was given

* Allow users to unsubscribe

* Use LTREE operator instead of recursive query

* Always show checkbox for push notifications

* Justify checkbox to end

* Update title of first push notification

* Fix warning from uncontrolled to controlled

* Add comment about Notification.requestPermission

* Fix timestamp

* Catch error on push subscription toggle

* Wrap function bodies in try/catch

* Use Promise.allSettled

* Filter subscriptions by user notification settings

* Fix user notification filter

* Use skipWaiting

---------

Co-authored-by: ekzyis <ek@stacker.news>
2023-07-04 14:36:07 -05:00
keyan
3e4161ae8c tip -> zap 2023-06-19 13:21:55 -05:00
keyan
f0f51438c4 add top posts/comments to subs 2023-06-12 19:40:18 -05:00
keyan
369bd82a84 make freebie comments visible case by case 2023-06-03 20:01:50 -05:00
ekzyis
ace2a4df3b
Match any port in dupe check (#297)
Co-authored-by: ekzyis <ek@stacker.news>
2023-05-31 19:49:28 -05:00
ekzyis
0c251ca376
Add thread subscriptions (#293)
* Add thread subscriptions

* remove dead code: reply only notifications

* break out thread subscription queries to reduce search space

* one db dip for item lists/threads re:meSubscription

---------

Co-authored-by: ekzyis <ek@stacker.news>
Co-authored-by: keyan <keyan.kousha+huumn@gmail.com>
2023-05-31 19:44:06 -05:00
keyan
0de134309c improve perf of rank view perf 2023-05-24 02:35:39 -05:00
keyan
28263bc6c7 rank views 2023-05-23 09:21:04 -05:00
keyan
2579a6b51c fix ranking function order operation in wild west mode 2023-05-09 15:07:23 -05:00
keyan
80968d7b35 let comments influence ranking 2023-05-09 13:52:35 -05:00
keyan
fbd746b023 fix auction ranking with query layers 2023-05-08 17:32:37 -05:00
keyan
67b815d9d6 preserve ordering in new layered item query 2023-05-08 15:06:42 -05:00
keyan
61d57056ed I dip you dip one db dip 2023-05-06 20:27:51 -05:00
keyan
1c608d42f4 denormalize votes 2023-05-06 18:53:10 -05:00
keyan
a97f8229b0 avoid extra dip when getting users 2023-05-06 18:18:18 -05:00
keyan
347a6a54d2 improve comment performance 2023-05-06 16:51:17 -05:00
keyan
3d4d86a40a simplify item queries with subs 2023-05-05 13:06:53 -05:00
keyan
abd9555792 fix recent comments 2023-05-04 19:20:48 -05:00
keyan
a241d683d8 nostr sub 2023-05-01 15:58:30 -05:00
keyan
e4a3095cb4 give pinned item recent sort by default 2023-03-19 10:43:33 -05:00
keyan
9afbe0abd8 enhance item related query perf 2023-02-24 10:35:05 -06:00
ekzyis
7b838cdeb2
Implement bookmarking of posts and comments (#235) 2023-02-16 16:23:59 -06:00
keyan
4cae1ae230 reuse validation on server 2023-02-08 13:39:53 -06:00
keyan
36ddb25b46 remove extra queries 2023-02-03 18:08:08 -06:00
keyan
291fe24363 denormalize bountyPaidTo 2023-01-26 17:28:10 -06:00
keyan
80f04b5a28 remove expensive query 2023-01-26 15:00:45 -06:00
keyan
d8e3e73def check for rootId 2023-01-26 13:37:51 -06:00
keyan
5306b11157 improve bounty performance 2023-01-26 13:09:57 -06:00
Austin Kelsay
e13e37744e
stackernews bounties (#227)
bounties
2023-01-26 10:11:55 -06:00
keyan
ceac96e149 dup /live variation of youtube link 2023-01-24 08:37:33 -06:00
keyan
29c59d93ea open timestamps 2023-01-22 14:17:50 -06:00
keyan
71e61e51e8 fix youtube dupe regex 2023-01-13 17:42:40 -06:00
keyan
9c0ead308b remove debug logging 2023-01-13 13:19:42 -06:00
keyan
10ff3fa1c3 delete 2023-01-13 11:52:18 -06:00
keyan
9823969418 unshorten links 2023-01-12 12:05:47 -06:00
keyan
afc9a70a02 ignore subdomains on dupe detection 2023-01-11 16:20:14 -06:00
keyan
2b878e1a19 more youtube dupe detection 2023-01-11 16:04:50 -06:00
keyan
b7830261d8 ignore case on url dupe detection 2023-01-11 15:05:30 -06:00
keyan
15c76aa134 recognize all youtube links 2023-01-11 14:58:52 -06:00
Keyan
10e5257375
Merge branch 'master' into 190-strip-tracking-info 2023-01-11 12:17:25 -06:00
keyan
439c83f975 all things being equal, sort comments by sats 2022-12-06 15:23:45 -06:00
keyan
2a4e5a0617 add more filters to recent 2022-12-01 16:42:49 -06:00
keyan
7df375e752 improvements to jobs 2022-11-29 11:29:43 -06:00
keyan
5746160893 let tips affect ranking 2022-11-23 12:12:09 -06:00
keyan
1bf747c7c0 sats to msats 2022-11-16 10:57:03 -06:00
ekzyis
3a36a211af Remove tracking from twitter URLs 2022-11-16 00:58:02 +01:00
keyan
368f74a7c5 3 hour cliff for all items 2022-10-31 12:56:48 -05:00
keyan
cb7f68e0e5 index wvotes for search 2022-10-28 10:58:31 -05:00
keyan
a398784f26 improved top 2022-10-25 16:35:32 -05:00