* Fix duplicate comment on pessimistic creation
- comment creation checks for comment's ID existence in cache
- invoice.confirmedAt included in useCanEdit deps for anons live comments
* switch to some as sets are not worth it
* only check for duplicates if a pessimistic payment method has been used
* default to empty array
* add comment about side-effects
* record ownership of an item to avoid injecting it via live comments
* trigger check only if the incoming comment is ours, cleanup
* correct conditions, correct comments, light cleanup
* fix: add defensive condition to ownership recorder, better name
* refactor: unified comment injection logic with deduplication, useCommentsView hook; revert sessionStorage-based fix
* adjust live comments naming around the codebase
* listen for hmac presence for anon edits
* always return the injected comment createdAt to bump live comments
* refactor: improve live comments hook readability
- latest comment createdAt persistence helper
- preserveScroll returns the returning value of the callback
- compact conditional logic
- refresh code comments
- refresh naming
- group constants
- reorder imports
* flat comment injection, fetch flat comments instead of the entire subtree that would've been deduplicated anyway, cleanup
* always align new comment fragment to the comments query structure
* generic useCommentsView hook
* update comment counts if live injecting into fragments without comments field
* fix: pass parentId, if a comment has a top level parent it always has the comments field
* fix: update CommentsViewAt only if we actually injected a comment into cache
* correct injectComment result usage
* pass markViewedAt to further centralize side effects, remove live from Item server typedefs
* fix: don't update counts for ancestors that are already up to date, update commentsViewedAt per batch not per comment
* port: fix coalesce, useCommentsView hook and outline changes
* update hmac field in cache on paid invoice, hmac as useCanEdit effect dependency
* comments and light cleanup, update useCommentsView
* efficient hasComments logic for live comments, establish a gql fragment
* fix: typo on topLevel evaluation
* limit extra evaluations to live comments scenarios
* update comments
* support live comments ncomments increments for anon view tracking
* enhance: FaviconProvider, keep track of new comment IDs to change favicon, remove new comment IDs per outline removal
* don't track oneself comments
* enhance: auto-show new comments, idempotency by ignoring already injected comments, preserveScroll utility
* fadeIn animation on comment injection; cleanup: remove unused counts and thread handling; non-critical fix: always give rootLastCommentAt a value
* reliably preserve scroll position by tracking a reference found at the center of the viewport; cleanup: add more comments, add cleanup function
* mitigate fractional scrolling subtle layout shifts by rounding the new reference element position
* enhanced outlining system, favicon context keeps track of new comments presence
- de-outlining now happens only for outlined comments
- enhanced outlining: add outline only if isNewComment
- de-outlining will remove the new comments favicon
- on unmount remove the new comments favicon
* remove the new comments favicon on new comments injection
* track only deduplicated new comments
* fix typo
* clearer unsetOutline conditions, fix typo in live comments hook
* backport: remove the injectedComment class from injected comments after animation ends
* set the new comments favicon on any new outlined comment
* enhance: directly inject new comments; cleanup: dismantle ShowNewComments, remove newComments field
* tweaks: slower injection animation, clear favicon on Comment section unmount
* change nDirectComments bug strategy to avoiding updates on comment edit
* cleanup: better naming, re-instate injected comments outline
* injection: major cache utilities refactor, don't preserve scroll if no comments have been injected
- don't preserve scroll if after deduplication we don't inject any comments
- use manual read/write cache updates to control the flow
-- allows to check if we are really injecting or not
- reduce polling to 5 seconds instead of 10
- light cleanup
-- removed update cache functions
-- added 'injected' to typeDefs (gql consistency)
* cleanup: detailed comments, refactor, remove clutter
Refactor:
+ clearer variables
+ depth calculation utility function
+ use destructured Apollo cache
+ extract item object from item query
+ skip ignored comment instead of ending the loop
CSS:
+ from-to fadeIn animation keyframes
- floatingComments unused class
Favicon:
+ provider exported by default
* fix wrong merge
* split: remove favicon context
* split: remove favicon pngs
* regression: revert to updateQuery for multiple comment fragments handling
* reverse multiple reads for deduplication on comment injection
* fix regression on apollo manipulations via fn; cleanup: remove wrong deps from outlining
