0032e064b2
* Poll failed invoices with visibility timeout * Don't return intermediate failed invoices * Don't retry too old invoices * Retry invoices on client * Only attempt payment 3 times * Fix fallbacks during last retry * Rename retry column to paymentAttempt * Fix no index used * Resolve TODOs * Use expiring locks * Better comments for constants * Acquire lock during retry * Use expiring lock in retry mutation * Use now() instead of CURRENT_TIMESTAMP * Cosmetic changes * Immediately show failed post payments in notifications * Update hasNewNotes * Never retry on user cancel For a consistent UX and less mental overhead, I decided to remove the exception for ITEM_CREATE where it would still retry in the background even though we want to show the payment failure immediately in notifications. * Fix notifications without pending retries missing if no send wallets If a stacker has no send wallets, they would miss notifications about failed payments because they would never get retried. This commit fixes this by making the notifications query aware if the stacker has send wallets. This way, it can tell if a notification will be retried or not. * Stop hiding userCancel in notifications As mentioned in a previous commit, I want to show anything that will not be attempted anymore in notifications. Before, I wanted to hide manually cancelled invoices but to not change experience unnecessarily and to decrease mental overhead, I changed my mind. * Also consider invoice.cancelledAt in notifications * Always retry failed payments, even without send wallets * Fix notification indicator on retry timeout * Set invoice.updated_at to date slightly in the future * Use default job priority * Stop retrying after one hour * Remove special case for ITEM_CREATE * Replace retryTimeout job with notification indicator query * Fix sortTime --------- Co-authored-by: Keyan <34140557+huumn@users.noreply.github.com>
90 lines
2.6 KiB
JavaScript
90 lines
2.6 KiB
JavaScript
import { retryPaidAction } from '../paidAction'
|
|
import { USER_ID, WALLET_MAX_RETRIES, WALLET_RETRY_TIMEOUT_MS } from '@/lib/constants'
|
|
|
|
function paidActionType (actionType) {
|
|
switch (actionType) {
|
|
case 'ITEM_CREATE':
|
|
case 'ITEM_UPDATE':
|
|
return 'ItemPaidAction'
|
|
case 'ZAP':
|
|
case 'DOWN_ZAP':
|
|
case 'BOOST':
|
|
return 'ItemActPaidAction'
|
|
case 'TERRITORY_CREATE':
|
|
case 'TERRITORY_UPDATE':
|
|
case 'TERRITORY_BILLING':
|
|
case 'TERRITORY_UNARCHIVE':
|
|
return 'SubPaidAction'
|
|
case 'DONATE':
|
|
return 'DonatePaidAction'
|
|
case 'POLL_VOTE':
|
|
return 'PollVotePaidAction'
|
|
case 'RECEIVE':
|
|
return 'ReceivePaidAction'
|
|
case 'BUY_CREDITS':
|
|
return 'BuyCreditsPaidAction'
|
|
default:
|
|
throw new Error('Unknown action type')
|
|
}
|
|
}
|
|
|
|
export default {
|
|
Query: {
|
|
paidAction: async (parent, { invoiceId }, { models, me }) => {
|
|
const invoice = await models.invoice.findUnique({
|
|
where: {
|
|
id: invoiceId,
|
|
userId: me?.id ?? USER_ID.anon
|
|
}
|
|
})
|
|
if (!invoice) {
|
|
throw new Error('Invoice not found')
|
|
}
|
|
|
|
return {
|
|
type: paidActionType(invoice.actionType),
|
|
invoice,
|
|
result: invoice.actionResult,
|
|
paymentMethod: invoice.actionOptimistic ? 'OPTIMISTIC' : 'PESSIMISTIC'
|
|
}
|
|
}
|
|
},
|
|
Mutation: {
|
|
retryPaidAction: async (parent, { invoiceId, newAttempt }, { models, me, lnd }) => {
|
|
if (!me) {
|
|
throw new Error('You must be logged in')
|
|
}
|
|
|
|
// make sure only one client at a time can retry by acquiring a lock that expires
|
|
const [invoice] = await models.$queryRaw`
|
|
UPDATE "Invoice"
|
|
SET "retryPendingSince" = now()
|
|
WHERE
|
|
id = ${invoiceId} AND
|
|
"userId" = ${me.id} AND
|
|
"actionState" = 'FAILED' AND
|
|
("retryPendingSince" IS NULL OR "retryPendingSince" < now() - ${`${WALLET_RETRY_TIMEOUT_MS} milliseconds`}::interval)
|
|
RETURNING *`
|
|
if (!invoice) {
|
|
throw new Error('Invoice not found or retry pending')
|
|
}
|
|
|
|
// do we want to retry a payment from the beginning with all sender and receiver wallets?
|
|
const paymentAttempt = newAttempt ? invoice.paymentAttempt + 1 : invoice.paymentAttempt
|
|
if (paymentAttempt > WALLET_MAX_RETRIES) {
|
|
throw new Error('Payment has been retried too many times')
|
|
}
|
|
|
|
const result = await retryPaidAction(invoice.actionType, { invoice }, { paymentAttempt, models, me, lnd })
|
|
|
|
return {
|
|
...result,
|
|
type: paidActionType(invoice.actionType)
|
|
}
|
|
}
|
|
},
|
|
PaidAction: {
|
|
__resolveType: obj => obj.type
|
|
}
|
|
}
|