stacker.news/wallets
Riccardo Balbo 2d139bed85
Blink wallet sending attachment (#1293)
* blink attachment

* support staging

* add staging dashboard link

* Revert "add staging dashboard link"

This reverts commit a43fa2204f03d74e733063aedd6862c6d71e4a46.

* Revert "support staging"

This reverts commit 93c15aa5083e60b1dafc77c30e999fb90fef8589.

* handle pending payments, code cleanup and comments

* stable sats -> stablesats

* catch HTTP errors

* print wallet currency in debug

* disable autocomplete

* schema without test()

* Fix save since default is not applied for empty strings

Formik validation must see 'currency' as undefined and apply the default but the validation before save sees an empty string.

* Save transformed config

* Remove unnecessary defaults

* Prefix HTTP error with text

---------

Co-authored-by: ekzyis <ek@stacker.news>
2024-08-18 11:36:55 -05:00
..
blink Blink wallet sending attachment (#1293) 2024-08-18 11:36:55 -05:00
cln Msats to sats floor (#1307) 2024-08-16 19:33:17 -05:00
lightning-address Msats to sats floor (#1307) 2024-08-16 19:33:17 -05:00
lnbits lnbits doesn't support msats either 2024-08-17 18:43:39 -05:00
lnc Wallet definitions with uniform interface (#1243) 2024-07-20 17:51:46 -05:00
lnd Msats to sats floor (#1307) 2024-08-16 19:33:17 -05:00
nwc not-custodial zap beta (#1178) 2024-08-13 09:48:30 -05:00
webln Use validation for WebLN wallet (#1277) 2024-07-24 10:08:09 -05:00
README.md Use validation for WebLN wallet (#1277) 2024-07-24 10:08:09 -05:00
client.js Blink wallet sending attachment (#1293) 2024-08-18 11:36:55 -05:00
index.js Blink wallet sending attachment (#1293) 2024-08-18 11:36:55 -05:00
package.json Wallet definitions with uniform interface (#1243) 2024-07-20 17:51:46 -05:00
server.js Msats to sats floor (#1307) 2024-08-16 19:33:17 -05:00
wrap.js Msats to sats floor (#1307) 2024-08-16 19:33:17 -05:00

README.md

Wallets

Every wallet that you can see at /settings/wallets is implemented as a plugin in this directory.

This README explains how you can add another wallet for use with Stacker News.

[!NOTE] Plugin means here that you only have to implement a common interface in this directory to add a wallet.

Plugin interface

Every wallet is defined inside its own directory. Every directory must contain an index.js and a client.js file.

An index.js file exports properties that can be shared by the client and server.

Wallets that have spending permissions / can pay invoices export the payment interface in client.js. These permissions are stored on the client.1

A server.js file is only required for wallets that support receiving by exposing the corresponding interface in that file. These wallets are stored on the server because payments are coordinated on the server so the server needs to generate these invoices for receiving. Additionally, permissions to receive a payment are not as sensitive as permissions to send a payment (highly sensitive!).

[!NOTE] Every wallet must have a client.js file (even if it does not support paying invoices) because every wallet is imported on the client. This is not the case on the server. On the client, wallets are imported via

import wallet from 'wallets/<name>/client'

vs

import wallet from 'wallets/<name>/server'

on the server.

To have access to the properties that can be shared between client and server, server.js and client.js always reexport everything in index.js with a line like this:

export * from 'wallets/<name>'

If a wallet does not support paying invoices, this is all that client.js of this wallet does. The reason for this structure is to make sure the client does not import dependencies that can only be imported on the server and would thus break the build.

[!WARNING] Wallets that support spending AND receiving have not been tested yet. For now, only implement either the interface for spending OR receiving until this warning is removed.

[!TIP] Don't hesitate to use the implementation of existing wallets as a reference.

index.js

An index.js file exports the following properties that are shared by imports of this wallet on the server and wallet:

  • name: string

This acts as an ID for this wallet on the client. It therefore must be unique across all wallets and is used throughout the code to reference this wallet. This name is also shown in the wallet logs.

  • shortName?: string

Since name will also be used in wallet logs, you can specify a shorter name here which will be used in logs instead.

  • fields: WalletField[]

Wallet fields define what this wallet requires for configuration and thus are used to construct the forms like the one you can see at /settings/wallets/lnbits.

  • card: WalletCard

Wallet cards are the components you can see at /settings/wallets. This property customizes this card for this wallet.

  • fieldValidation: (config) => { [key: string]: string } | Yup.ObjectSchema

This property defines how Formik should perform form-level validation. As mentioned in the documentation, Formik supports two ways to perform such validation.

If a function is used for fieldValidation, the built-in form-level validation is used via the validate property of the Formik form component.

If a Yup object schema is set, validationSchema will be used instead.

This validation is triggered on every submit and on every change after the first submit attempt.

Refer to the Formik documentation for more details.

  • walletType?: string

This field is only required if this wallet supports receiving payments. It must match a value of the enum WalletType in the database.

  • walletField?: string

Just like walletType, this field is only required if this wallet supports receiving payments. It must match a column in the Wallet table.

[!NOTE] This is the only exception where you have to write code outside this directory for a wallet that supports receiving: you need to write a database migration to add a new enum value to WalletType and column to Wallet. See the top-level README for how to do this.

WalletField

A wallet field is an object with the following properties:

  • name: string

The configuration key. This is used by Formik to map values to the correct input. This key is also what is used to save values in local storage or the database. For wallets that are stored on the server, this must therefore match a column in the corresponding table for wallets of this type.

  • label: string

The label of the configuration key. Will be shown to the user in the form.

  • type: 'text' | 'password'

The input type that should be used for this value. For example, if the type is password, the input value will be hidden by default using a component for passwords.

  • optional?: boolean | string = false

This property can be used to mark a wallet field as optional. If it is not set, we will assume this field is required else 'optional' will be shown to the user next to the label. You can use Markdown to customize this text.

  • help?: string | { label: string, text: string }

If this property is set, a help icon will be shown to the user. On click, the specified text in Markdown is shown. If you additionally want to customize the icon label, you can use the object syntax.

  • editable?: boolean = true

If this property is set to false, you can only configure this value once. Afterwards, it's read-only. To configure it again, you have to detach the wallet first.

  • placeholder?: string = ''

Placeholder text to show an example value to the user before they click into the input.

  • hint?: string = ''

If a hint is set, it will be shown below the input.

  • clear?: boolean = false

If a button to clear the input after it has been set should be shown, set this property to true.

  • autoComplete?: HTMLAttribute<'autocomplete'>

This property controls the HTML autocomplete attribute. See the documentation for possible values. Not setting it usually means that the user agent can use autocompletion. This property has no effect for passwords. Autocompletion is always turned off for passwords to prevent passwords getting saved for security reasons.

WalletCard

  • title: string

The card title.

  • subtitle: string

The subtitle that is shown below the title if you enter the configuration form of a wallet.

  • badges: string[]

The badges that are shown inside the card.

client.js

A wallet that supports paying invoices must export the following properties in client.js which are only available if this wallet is imported on the client:

  • testConnectClient: async (config, context) => Promise<void>

testConnectClient will be called during submit on the client to validate the configuration (that is passed as the first argument) more thoroughly than the initial validation by fieldValidation. It contains validation code that should only be called during submits instead of possibly on every change like fieldValidation.

How this validation is implemented depends heavily on the wallet. For example, for NWC, this function attempts to fetch the info event from the relay specified in the connection string whereas for LNbits, it makes an HTTP request to /api/v1/wallet using the given URL and API key.

This function must throw an error if the configuration was found to be invalid.

The context argument is an object. It makes the wallet logger for this wallet as returned by useWalletLogger available under context.logger. See components/wallet-logger.js.

  • sendPayment: async (bolt11: string, config, context) => Promise<{ preimage: string }>

sendPayment will be called if a payment is required. Therefore, this function should implement the code to pay invoices from this wallet.

The first argument is the BOLT11 payment request. The config argument is the current configuration of this wallet (that was validated before). The context argument is the same as for testConnectClient.

[!IMPORTANT] As mentioned above, this file must exist for every wallet and at least reexport everything in index.js so make sure that the following line is included:

export * from 'wallets/<name>'

where <name> is the wallet directory name.

[!IMPORTANT] After you're done implementing the interface, you need to import this wallet in wallets/client.js and add it to the array that is the default export of that file to make this wallet available across the code:

// wallets/client.js
import * as nwc from 'wallets/nwc/client'
import * as lnbits from 'wallets/lnbits/client'
import * as lnc from 'wallets/lnc/client'
import * as lnAddr from 'wallets/lightning-address/client'
import * as cln from 'wallets/cln/client'
import * as lnd from 'wallets/lnd/client'
+ import * as newWallet from 'wallets/<name>/client'

- export default [nwc, lnbits, lnc, lnAddr, cln, lnd]
+ export default [nwc, lnbits, lnc, lnAddr, cln, lnd, newWallet]

server.js

A wallet that supports receiving must export the following properties in server.js which are only available if this wallet is imported on the server:

  • testConnectServer: async (config, context) => Promise<void>

testConnectServer is called on the server during submit and can thus use server dependencies like ln-service.

It should attempt to create a test invoice to make sure that this wallet can later create invoices for receiving.

Again, like testConnectClient, the first argument is the wallet configuration that we should validate and this should thrown an error if validation fails. However, unlike testConnectClient, the context argument here contains me (the user object) and models (the Prisma client).

  • createInvoice: async (amount: int, config, context) => Promise<bolt11: string>

createInvoice will be called whenever this wallet should receive a payment. It should return a BOLT11 payment request. The first argument amount specifies the amount in satoshis. The second argument config is the current configuration of this wallet. The third argument context is the same as in testConnectServer except it also includes lnd which is the return value of authenticatedLndGrpc using the SN node credentials.

[!IMPORTANT] Don't forget to include the following line:

export * from 'wallets/<name>'

where <name> is the wallet directory name.

[!IMPORTANT] After you're done implementing the interface, you need to import this wallet in wallets/server.js and add it to the array that is the default export of that file to make this wallet available across the code:

// wallets/server.js
import * as lnd from 'wallets/lnd/server'
import * as cln from 'wallets/cln/server'
import * as lnAddr from 'wallets/lightning-address/server'
+ import * as newWallet from 'wallets/<name>/client'

- export default [lnd, cln, lnAddr]
+ export default [lnd, cln, lnAddr, newWallet]

  1. unencrypted in local storage until we have implemented encrypted local storage. ↩︎