15bd1c3fc5
* Fix the check for misleading links * replace tabs with spaces * remove trailing spaces * move isMisleadingLinks to lib/url.js and create unit tests * Add comments to test cases * URLs can contain hyphens --------- Co-authored-by: ekzyis <ek@stacker.news>
59 lines
2.2 KiB
JavaScript
59 lines
2.2 KiB
JavaScript
/* eslint-env jest */
|
|
|
|
import { parseInternalLinks, isMisleadingLink } from './url.js'
|
|
|
|
const internalLinkCases = [
|
|
['https://stacker.news/items/123', '#123'],
|
|
['https://stacker.news/items/123/related', '#123/related'],
|
|
// invalid links should not be parsed so user can spot error
|
|
['https://stacker.news/items/123foobar', undefined],
|
|
// Invalid origin should not be parsed so no malicious links
|
|
['https://example.com/items/123', undefined],
|
|
// parse referral links
|
|
['https://stacker.news/items/123/r/ekzyis', '#123'],
|
|
// use comment id if available
|
|
['https://stacker.news/items/123?commentId=456', '#456'],
|
|
// comment id + referral link
|
|
['https://stacker.news/items/123/r/ekzyis?commentId=456', '#456'],
|
|
// multiple params
|
|
['https://stacker.news/items/123?commentId=456&parentId=789', '#456']
|
|
]
|
|
|
|
describe('internal links', () => {
|
|
test.each(internalLinkCases)(
|
|
'parses %p as %p',
|
|
(href, expected) => {
|
|
process.env.NEXT_PUBLIC_URL = 'https://stacker.news'
|
|
const { linkText: actual } = parseInternalLinks(href)
|
|
expect(actual).toBe(expected)
|
|
}
|
|
)
|
|
})
|
|
|
|
const misleadingLinkCases = [
|
|
// if text is the same as the link, it's not misleading
|
|
['https://stacker.news/items/1234', 'https://stacker.news/items/1234', false],
|
|
// same origin is not misleading
|
|
['https://stacker.news/items/1235', 'https://stacker.news/items/1234', false],
|
|
['www.google.com', 'https://www.google.com', false],
|
|
['stacker.news', 'https://stacker.news', false],
|
|
// if text is obviously not a link, it's not misleading
|
|
['innocent text', 'https://stacker.news/items/1234', false],
|
|
['innocenttext', 'https://stacker.news/items/1234', false],
|
|
// if text might be a link to a different origin, it's misleading
|
|
['innocent.text', 'https://stacker.news/items/1234', true],
|
|
['https://google.com', 'https://bing.com', true],
|
|
['www.google.com', 'https://bing.com', true],
|
|
['s-tacker.news', 'https://snacker.news', true]
|
|
]
|
|
|
|
describe('misleading links', () => {
|
|
test.each(misleadingLinkCases)(
|
|
'identifies [%p](%p) as misleading: %p',
|
|
(text, href, expected) => {
|
|
const actual = isMisleadingLink(text, href)
|
|
expect(actual).toBe(expected)
|
|
}
|
|
)
|
|
})
|