Go to file
ekzyis 8f590425dc
Image uploads (#576)
* Add icon to add images

* Open file explorer to select image

* Upload images to S3 on selection

* Show uploaded images below text input

* Link and remove image

* Fetch unsubmitted images from database

* Mark S3 images as submitted in imgproxy job

* Add margin-top

* Mark images as submitted on client after successful mutation

* Also delete objects in S3

* Allow items to have multiple uploads linked

* Overwrite old avatar

* Add fees for presigned URLs

* Use Github style upload

* removed upfront fees
* removed images provider since we no longer need to keep track of unsubmitted images on the client
* removed User.images resolver
* removed deleteImage mutation
* use Github style upload where it shows ![Uploading <filename>...]() first and then replaces that with ![<filename>](<url>) after successful upload

* Add Upload.paid boolean column

One item can have multiple images linked to it, but an image can also be used in multiple items (many-to-many relation).

Since we don't really care to which item an image is linked and vice versa, we just use a boolean column to mark if an image was already paid for.

This makes fee calculation easier since no JOINs are required.

* Add image fees during item creation/update

* we calculate image fees during item creation and update now
* function imageFees returns queries which deduct fees from user and mark images as paid + fees
* queries need to be run inside same transaction as item creation/update

* Allow anons to get presigned URLs

* Add comments regarding avatar upload

* Use megabytes in error message

* Remove unnecessary avatar check during image fees calculation

* Show image fees in frontend

* Also update image fees on blur

This makes sure that the images fees reflect the current state. For example, if an image was removed.

We could also add debounced requests.

* Show amount of unpaid images in receipt

* Fix fees in sats deducted from msats

* Fix algebraic order of fees

Spam fees must come immediately after the base fee since it multiplies the base fee.

* Fix image fees in edit receipt

* Fix stale fees shown

If we pay for an image and then want to edit the comment, the cache might return stale date; suggesting we didn't pay for the existing image yet.

* Add 0 base fee in edit receipt

* Remove 's' from 'image fees' in receipts

* Remove unnecessary async

* Remove 'Uploading <name>...' from text input on error

* Support upload of multiple files at once

* Add schedule to delete unused images

* Fix image fee display in receipts

* Use Drag and Drop API for image upload

* Remove dragOver style on drop

* Increase max upload size to 10MB to allow HQ camera pictures

* Fix free upload quota

* Fix stale image fees served

* Fix bad image fee return statements

* Fix multiplication with feesPerImage

* Fix NULL returned for size24h, sizeNow

* Remove unnecessary text field in query

* refactor: Unify <ImageUpload> and <Upload> component

* Add avatar cache busting using random query param

* Calculate image fee info in postgres function

* we now calculate image fee info in a postgres function which is much cleaner
* we use this function inside `create_item` and `update_item`: image fees are now deducted in the same transaction as creating/updating the item!
* reversed changes in `serializeInvoiceable`

* Fix line break in receipt

* Update upload limits

* Add comment about `e.target.value = null`

* Use debounce instead of onBlur to update image fees info

* Fix invoice amount

* Refactor avatar upload control flow

* Update image fees in onChange

* Fix rescheduling of other jobs

* also update schedule from every minute to every hour

* Add image fees in calling context

* keep item ids on uploads

* Fix incompatible onSubmit signature

* Revert "keep item ids on uploads"

This reverts commit 4688962abc.

* many2many item uploads

* pretty subdomain for images

* handle upload conditions for profile images and job logos

---------

Co-authored-by: ekzyis <ek@ekzyis.com>
Co-authored-by: ekzyis <ek@stacker.news>
2023-11-06 14:53:33 -06:00
.ebextensions add lb based scaling health check 2023-08-02 21:33:53 -05:00
.github Eslint setup and github action (#360) 2023-08-07 18:43:15 -05:00
.platform Remove Content-Length header for requests to /api/lnauth (#413) 2023-08-15 12:52:56 -05:00
.vscode remove vscode settings 2022-06-08 16:56:35 -05:00
api Image uploads (#576) 2023-11-06 14:53:33 -06:00
components Image uploads (#576) 2023-11-06 14:53:33 -06:00
docs Fix quote selection reply in iOS Safari (#544) 2023-10-05 19:32:54 -05:00
fragments fix markdown inline code and headings 2023-10-23 17:14:37 -05:00
lib Image uploads (#576) 2023-11-06 14:53:33 -06:00
pages Revert "halloween animation" 2023-11-01 11:57:55 -05:00
prisma Image uploads (#576) 2023-11-06 14:53:33 -06:00
public add /bitcoin.pdf easter egg 2023-10-31 11:02:13 -05:00
scripts add top meme and fact to newsletter script 2023-10-28 18:28:13 -05:00
spawn upgrade deps 2022-11-06 11:28:58 -06:00
styles small adjustments to secondary form text 2023-10-26 15:12:21 -05:00
svgs add prism logo 2023-09-26 16:44:57 -05:00
sw Resubscribe if service worker lost push subscription (#597) 2023-11-05 15:08:44 -06:00
worker Image uploads (#576) 2023-11-06 14:53:33 -06:00
.babelrc dark mode with css variables instead 2021-11-09 16:43:56 -06:00
.env.sample Move OPENSEARCH env vars to optional section 2023-10-13 22:11:50 +02:00
.gitignore remove slashtags completely 2023-08-17 13:40:21 -05:00
.npmrc Revert "Revert "shield your eyes; massive, squashed refactor; nextjs/react/react-dom/apollo upgrades"" 2023-07-23 10:08:43 -05:00
.puppeteerrc.cjs puppeteer config 2022-11-16 10:57:03 -06:00
Dockerfile use node v18 in docker 2023-08-07 13:19:11 -05:00
LICENSE add license 2021-06-28 18:28:26 -05:00
Procfile fix module issues when running worker 2023-09-26 20:33:54 -05:00
README.md Update README.md (#593) 2023-11-01 14:54:41 -05:00
contributors.txt Verify invoice amount in lightning address withdrawal (#501) 2023-09-23 20:21:40 -05:00
docker-compose.yml fix module issues when running worker 2023-09-26 20:33:54 -05:00
middleware.js referrals 2022-12-19 16:27:52 -06:00
next.config.js Closes #601 Fix next.config.js to apply res headers to ttf font (#602) 2023-11-05 15:10:23 -06:00
package-lock.json update packages 2023-10-15 15:43:06 -05:00
package.json update packages 2023-10-15 15:43:06 -05:00

README.md

contributing

We pay sats for PRs. Sats will be proportional to the impact of the PR. If there's something you'd like to work on, suggest how much you'd do it for on the issue. If there's something you'd like to work on that isn't already an issue, whether its a bug fix or a new feature, create one.

We aim to have a quick PR turnaround time, but we are sometimes slower than we'd like. In most cases, if your PR is unambiguously good, it shouldn't take us more than 1 week.

If you have a question about contributing start a discussion.

responsible disclosure

If you found a vulnerability, we would greatly appreciate it if you contact us via kk@stacker.news or t.me/k00bideh.

stacker.news

Stacker News is like Hacker News but we pay you Bitcoin. We use Bitcoin and the Lightning Network to provide Sybil resistance and any karma earned is withdrawable as Bitcoin.

wen decentralization

We're experimenting with providing an SN-like service on nostr in Outer Space. It's our overarching goal to align SN with Bitcoin's ethos yet still make a product the average bitcoiner loves to use.

local development

  1. Install docker-compose and deps if you don't already have it installed
  2. git clone git@github.com:stackernews/stacker.news.git sn && cd sn
  3. docker-compose up --build

You should then be able to access the site at localhost:3000 and any changes you make will hot reload. If you want to login locally or use lnd you'll need to modify .env.sample appropriately. More details here and here. If you have trouble please open an issue so I can help and update the README for everyone else.

web push

To enable Web Push locally, you will need to set the VAPID_* env vars. VAPID_MAILTO needs to be an email address using the mailto: scheme. For NEXT_PUBLIC_VAPID_KEY and VAPID_PRIVKEY, you can run npx web-push generate-vapid-keys.

imgproxy

To configure the image proxy, you will need to set the IMGPROXY_ env vars. NEXT_PUBLIC_IMGPROXY_URL needs to point to the image proxy service. IMGPROXY_KEY and IMGPROXY_SALT can be set using openssl rand -hex 64.

stack

The site is written in javascript using Next.js, a React framework. The backend API is provided via GraphQL. The database is PostgreSQL modeled with Prisma. The job queue is also maintained in PostgreSQL. We use lnd for our lightning node. A customized Bootstrap theme is used for styling.

processes

There are two. 1. the web app and 2. the worker, which dequeues jobs sent to it by the web app, e.g. polling lnd for invoice/payment status

wallet transaction safety

To ensure stackers balances are kept sane, all wallet updates are run in serializable transactions at the database level. Because prisma has relatively poor support for transactions all wallet touching code is written in plpgsql stored procedures and can be found in the prisma/migrations folder.

code

The code is linted with standardjs.

license

MIT