* check new comments every 10 seconds * enhance: clear newComments on child comments when we show a topLevel new comment; cleanup: resolvers, logs * handle comments of comments, new structure to clear newComments on childs * use original recursive comments data structure * correct comment structure after deduplication * faster newComments query deduplication, don't need to know how many comments are there * cleanup: comments on newComments fetches and dedupes * cleanup, use correct function declarations * stop polling after 30 minutes, pause polling if user is not on the page * ActionTooltip indicating that the user is in a live comment section * handleVisibilityChange to control polling by visibility * paused polling styling, check activity on 1 minute intervals and visibility change, light cleanup * user can resume polling without refreshing the page * better naming, straightforward dedupeComment on newComment arrival * cleanup: better naming, get latest comment creation, correct order of comment injection * cleanup: refactor live comments related functions to use-live-comments.js * refactor: clearer naming, optimized polling and date retrieval logic, use of constants, general cleanup * ui: place ShowNewComments in the bottom-right corner of nested comments * fix: make updateQuery sort-aware to correctly inject the comment in the correct Item query * cleanup: better naming; fix: usecallback on live comments component; fix leak on useEffect because of missing sort atomic apollo cache manipulations; manage top sort not being present in item query cache queue nested comments without a parent, retry on the next poll fix commit messages * fix: don't show unpaid comments; cleanup: compact cache merge/dedupe, queue comments via state * fix: read new comments fragments to inject fresh new comments, fixing dropped comments; ui: show amount of new comments refactor: correct function positioning; cleanup: useless logs * enhance: queuedComments Ref, cache-and-network fetch policy; freshNewComments readFragment fallback to received comment * cleanup: detailed comments and better ShowNewComment text * fix: while showing new comments, also update ncomments for UI and pagination * refactor: ShowNewComments is its own component; cleanup: proven useless dedupe on ShowNewComments, count nested ncomments from fresh new comments * enhance: direct latest comment createdAt calc with reduce * cleanup queue on unmount * feat: live comments indicator for bottomed-out replies, ncomments updates; fix: nested comment structures - new comments indicator for bottomed-out replies - ncomments sync for parent and its ancestors - limited comments fragment for comments that don't have CommentsRecursive - reduce cache complexity by removing useless roundtrips ux: live comments indicator on bottomedOut replies fix: dedupe newComments before displaying ShowNewComments to avoid false positives enhance: store ids of new comments in the cache, instead of carrying full comments that would get discarded anyway hotfix: newComments deduplication ID mismatch, filter null comments from freshNewComments fix: ncomments not updating for all comment levels; refactor: share Reply update ancestors' ncomments function with ShowNewComments cleanup: better naming to indicate the total number of comments including nested comments fix: increment parent comment ncomments cleanup: Items that will have comments will always have a structure where item.comments is true cleanup: reduce code complexity checking the nested comment update result instead of preventively reading the fragment cleanup: avoid double-updating ncomments on parent fix: don't use CommentsRecursive for bottomed-out comments cleanup: better fragment naming; add TODO for absolute bottom comments * backport live comments logic enhancements use-live-comments: - remove useless dedupe against already present comments - check newComments.comments length to tell if there are new comments - code reordering show-new-comments: - show all new comments recursively for nested comments - get always the newest comments to inject also their own child new comments - update local storage commentsViewedAt on comment injection - respect depth on comment injection comments.js - apollo cache manipulations now live here * hotfix: handle undefined item.comments.comments on dedupe * hotfix: limited fragment for recursive comment collection; protect from null fragments; add missing deps to memoization * docs: clarify ncomments updates * cleanup: remove unused export * count and show only the direct new comments and recursively their children enhance: dedupe against existing comments only in the component enhance: recursive count/injection share the same logic * fix regression on top level counting * hotfix: introduce readNestedCommentsFragment in lib/comments.js * fix: count also existing comments of a new comment; cleanup: use readCommentFragment also for prepareComments; reduce freshNewComments usage * add support for comments at the deepest level fixes: - client-side navigation re-fetched all new comments because 'after' was cached, now the latest new comment time persists in sessionStorage enhancements: - use CommentWithNewMinimal fragment fallback for comments at the deepest level - tweak ReplyOnAnotherPage to show also how many direct new comments are there cleanup: - queue management is not needed anymore, therefore it has been removed * cleanup: remove logs * revert counting on ReplyOnAnotherPage, TODO for enhancements PR * move ShowNewComments to CommentsHeader for top level comments * fix: update commentsViewedAfterComment to support ncomments * fix typo, lint * cleanup: remove old CSS * enhance: inject topLevel and its children new comments, simplify injection logic - top-level and nested comment handling share the same recursion logic - ShowNewComments references the item object for every type of comments — note: item from item-full.js is passed to comments.js - depth now starts at 0 to support top level comments - injection and counting now reach the deepest level, updating also the deepest comment * cleanup: remove unused topLevel prop * fix: deepest comments don't have CommentsRecursive structure, don't access it on injection * move top level ShowNewComments above CommentsHeader; preserve space to avoid vertical layout shifting * cleanup: remove unused item on CommentsHeader --------- Co-authored-by: Keyan <34140557+huumn@users.noreply.github.com>
136 lines
5.2 KiB
JavaScript
136 lines
5.2 KiB
JavaScript
import { useCallback } from 'react'
|
|
import { useApolloClient } from '@apollo/client'
|
|
import styles from './comment.module.css'
|
|
import { COMMENT_DEPTH_LIMIT } from '../lib/constants'
|
|
import { commentsViewedAfterComment } from '../lib/new-comments'
|
|
import {
|
|
itemUpdateQuery,
|
|
commentUpdateFragment,
|
|
getLatestCommentCreatedAt,
|
|
updateAncestorsCommentCount,
|
|
readCommentsFragment
|
|
} from '../lib/comments'
|
|
|
|
// filters out new comments, by id, that already exist in the item's comments
|
|
// preventing duplicate comments from being injected
|
|
function dedupeNewComments (newComments, comments = []) {
|
|
const existingIds = new Set(comments.map(c => c.id))
|
|
return newComments.filter(id => !existingIds.has(id))
|
|
}
|
|
|
|
// prepares and creates a new comments fragment for injection into the cache
|
|
// returns a function that can be used to update an item's comments field
|
|
function prepareComments ({ client, newComments }) {
|
|
return (data) => {
|
|
// count total comments being injected: each new comment + all their existing nested comments
|
|
let totalNComments = newComments.length
|
|
for (const comment of newComments) {
|
|
// add all nested comments (subtree) under this newly injected comment to the total
|
|
totalNComments += (comment.ncomments || 0)
|
|
}
|
|
|
|
// update all ancestors, but not the item itself
|
|
const ancestors = data.path.split('.').slice(0, -1)
|
|
updateAncestorsCommentCount(client.cache, ancestors, totalNComments)
|
|
|
|
// update commentsViewedAt with the most recent fresh new comment
|
|
// quirk: this is not the most recent comment, it's the most recent comment in the newComments array
|
|
// as such, the next visit will not outline other new comments that are older than this one.
|
|
const latestCommentCreatedAt = getLatestCommentCreatedAt(newComments, data.createdAt)
|
|
const rootId = data.path.split('.')[0]
|
|
commentsViewedAfterComment(rootId, latestCommentCreatedAt, totalNComments)
|
|
|
|
// return the updated item with the new comments injected
|
|
return {
|
|
...data,
|
|
comments: { ...data.comments, comments: [...newComments, ...(data.comments?.comments || [])] },
|
|
ncomments: data.ncomments + totalNComments,
|
|
newComments: []
|
|
}
|
|
}
|
|
}
|
|
|
|
// traverses all new comments and their children
|
|
// at each level, we can execute a callback giving the new comments and the item
|
|
function traverseNewComments (client, item, onLevel, currentDepth = 1) {
|
|
if (currentDepth > COMMENT_DEPTH_LIMIT) return
|
|
|
|
if (item.newComments && item.newComments.length > 0) {
|
|
const dedupedNewComments = dedupeNewComments(item.newComments, item.comments?.comments)
|
|
|
|
// being newComments an array of comment ids, we can get their latest version from the cache
|
|
// ensuring that we don't miss any new comments
|
|
const freshNewComments = dedupedNewComments.map(id => {
|
|
return readCommentsFragment(client, id)
|
|
}).filter(Boolean)
|
|
|
|
// passing currentDepth allows children of top level comments
|
|
// to be updated by the commentUpdateFragment
|
|
onLevel(freshNewComments, item, currentDepth)
|
|
|
|
for (const newComment of freshNewComments) {
|
|
traverseNewComments(client, newComment, onLevel, currentDepth + 1)
|
|
}
|
|
}
|
|
}
|
|
|
|
// recursively processes and displays all new comments and its children
|
|
// handles comment injection at each level, respecting depth limits
|
|
function injectNewComments (client, item, currentDepth, sort) {
|
|
traverseNewComments(client, item, (newComments, item, depth) => {
|
|
if (newComments.length > 0) {
|
|
const payload = prepareComments({ client, newComments })
|
|
|
|
// used to determine if by iterating through the new comments
|
|
// we are injecting topLevels (depth 0) or not
|
|
if (depth === 0) {
|
|
itemUpdateQuery(client, item.id, sort, payload)
|
|
} else {
|
|
commentUpdateFragment(client, item.id, payload)
|
|
}
|
|
}
|
|
}, currentDepth)
|
|
}
|
|
|
|
// counts all new comments for an item and its children
|
|
function countAllNewComments (client, item, currentDepth = 1) {
|
|
let totalNComments = 0
|
|
|
|
// count by traversing all new comments and their children
|
|
traverseNewComments(client, item, (newComments) => {
|
|
totalNComments += newComments.length
|
|
for (const newComment of newComments) {
|
|
totalNComments += newComment.ncomments || 0
|
|
}
|
|
}, currentDepth)
|
|
|
|
return totalNComments
|
|
}
|
|
|
|
// ShowNewComments is a component that dedupes, refreshes and injects newComments into the comments field
|
|
export function ShowNewComments ({ item, sort, depth = 0 }) {
|
|
const client = useApolloClient()
|
|
|
|
// recurse through all new comments and their children
|
|
const newCommentsCount = item.newComments?.length > 0 ? countAllNewComments(client, item, depth) : 0
|
|
|
|
const showNewComments = useCallback(() => {
|
|
// a top level comment doesn't have depth, we pass 0 to signify this
|
|
// other comments are injected from their depth
|
|
injectNewComments(client, item, depth, sort)
|
|
}, [client, sort, item, depth])
|
|
|
|
return (
|
|
<span
|
|
onClick={showNewComments}
|
|
className='fw-bold d-flex align-items-center gap-2 px-3 pointer'
|
|
style={{ visibility: newCommentsCount > 0 ? 'visible' : 'hidden' }}
|
|
>
|
|
{newCommentsCount > 1
|
|
? `${newCommentsCount} new comments`
|
|
: 'show new comment'}
|
|
<div className={styles.newCommentDot} />
|
|
</span>
|
|
)
|
|
}
|