* check new comments every 10 seconds * enhance: clear newComments on child comments when we show a topLevel new comment; cleanup: resolvers, logs * handle comments of comments, new structure to clear newComments on childs * use original recursive comments data structure * correct comment structure after deduplication * faster newComments query deduplication, don't need to know how many comments are there * cleanup: comments on newComments fetches and dedupes * cleanup, use correct function declarations * stop polling after 30 minutes, pause polling if user is not on the page * ActionTooltip indicating that the user is in a live comment section * handleVisibilityChange to control polling by visibility * paused polling styling, check activity on 1 minute intervals and visibility change, light cleanup * user can resume polling without refreshing the page * better naming, straightforward dedupeComment on newComment arrival * cleanup: better naming, get latest comment creation, correct order of comment injection * cleanup: refactor live comments related functions to use-live-comments.js * refactor: clearer naming, optimized polling and date retrieval logic, use of constants, general cleanup * ui: place ShowNewComments in the bottom-right corner of nested comments * fix: make updateQuery sort-aware to correctly inject the comment in the correct Item query * cleanup: better naming; fix: usecallback on live comments component; fix leak on useEffect because of missing sort atomic apollo cache manipulations; manage top sort not being present in item query cache queue nested comments without a parent, retry on the next poll fix commit messages * fix: don't show unpaid comments; cleanup: compact cache merge/dedupe, queue comments via state * fix: read new comments fragments to inject fresh new comments, fixing dropped comments; ui: show amount of new comments refactor: correct function positioning; cleanup: useless logs * enhance: queuedComments Ref, cache-and-network fetch policy; freshNewComments readFragment fallback to received comment * cleanup: detailed comments and better ShowNewComment text * fix: while showing new comments, also update ncomments for UI and pagination * refactor: ShowNewComments is its own component; cleanup: proven useless dedupe on ShowNewComments, count nested ncomments from fresh new comments * enhance: direct latest comment createdAt calc with reduce * cleanup queue on unmount * feat: live comments indicator for bottomed-out replies, ncomments updates; fix: nested comment structures - new comments indicator for bottomed-out replies - ncomments sync for parent and its ancestors - limited comments fragment for comments that don't have CommentsRecursive - reduce cache complexity by removing useless roundtrips ux: live comments indicator on bottomedOut replies fix: dedupe newComments before displaying ShowNewComments to avoid false positives enhance: store ids of new comments in the cache, instead of carrying full comments that would get discarded anyway hotfix: newComments deduplication ID mismatch, filter null comments from freshNewComments fix: ncomments not updating for all comment levels; refactor: share Reply update ancestors' ncomments function with ShowNewComments cleanup: better naming to indicate the total number of comments including nested comments fix: increment parent comment ncomments cleanup: Items that will have comments will always have a structure where item.comments is true cleanup: reduce code complexity checking the nested comment update result instead of preventively reading the fragment cleanup: avoid double-updating ncomments on parent fix: don't use CommentsRecursive for bottomed-out comments cleanup: better fragment naming; add TODO for absolute bottom comments * backport live comments logic enhancements use-live-comments: - remove useless dedupe against already present comments - check newComments.comments length to tell if there are new comments - code reordering show-new-comments: - show all new comments recursively for nested comments - get always the newest comments to inject also their own child new comments - update local storage commentsViewedAt on comment injection - respect depth on comment injection comments.js - apollo cache manipulations now live here * hotfix: handle undefined item.comments.comments on dedupe * hotfix: limited fragment for recursive comment collection; protect from null fragments; add missing deps to memoization * docs: clarify ncomments updates * cleanup: remove unused export * count and show only the direct new comments and recursively their children enhance: dedupe against existing comments only in the component enhance: recursive count/injection share the same logic * fix regression on top level counting * hotfix: introduce readNestedCommentsFragment in lib/comments.js * fix: count also existing comments of a new comment; cleanup: use readCommentFragment also for prepareComments; reduce freshNewComments usage * add support for comments at the deepest level fixes: - client-side navigation re-fetched all new comments because 'after' was cached, now the latest new comment time persists in sessionStorage enhancements: - use CommentWithNewMinimal fragment fallback for comments at the deepest level - tweak ReplyOnAnotherPage to show also how many direct new comments are there cleanup: - queue management is not needed anymore, therefore it has been removed * cleanup: remove logs * revert counting on ReplyOnAnotherPage, TODO for enhancements PR * move ShowNewComments to CommentsHeader for top level comments * fix: update commentsViewedAfterComment to support ncomments * fix typo, lint * cleanup: remove old CSS * enhance: inject topLevel and its children new comments, simplify injection logic - top-level and nested comment handling share the same recursion logic - ShowNewComments references the item object for every type of comments — note: item from item-full.js is passed to comments.js - depth now starts at 0 to support top level comments - injection and counting now reach the deepest level, updating also the deepest comment * cleanup: remove unused topLevel prop * fix: deepest comments don't have CommentsRecursive structure, don't access it on injection * move top level ShowNewComments above CommentsHeader; preserve space to avoid vertical layout shifting * cleanup: remove unused item on CommentsHeader --------- Co-authored-by: Keyan <34140557+huumn@users.noreply.github.com>
76 lines
3.0 KiB
JavaScript
76 lines
3.0 KiB
JavaScript
import { useQuery, useApolloClient } from '@apollo/client'
|
|
import { SSR } from '../lib/constants'
|
|
import { GET_NEW_COMMENTS } from '../fragments/comments'
|
|
import { useEffect, useState } from 'react'
|
|
import { itemUpdateQuery, commentUpdateFragment, getLatestCommentCreatedAt } from '../lib/comments'
|
|
|
|
const POLL_INTERVAL = 1000 * 10 // 10 seconds
|
|
|
|
// merge new comment into item's newComments
|
|
// and prevent duplicates by checking if the comment is already in item's newComments
|
|
function mergeNewComment (item, newComment) {
|
|
const existingNewComments = item.newComments || []
|
|
|
|
// is the incoming new comment already in item's new comments?
|
|
if (existingNewComments.includes(newComment.id)) {
|
|
return item
|
|
}
|
|
|
|
return { ...item, newComments: [...existingNewComments, newComment.id] }
|
|
}
|
|
|
|
function cacheNewComments (client, rootId, newComments, sort) {
|
|
for (const newComment of newComments) {
|
|
const { parentId } = newComment
|
|
const topLevel = Number(parentId) === Number(rootId)
|
|
|
|
// if the comment is a top level comment, update the item
|
|
if (topLevel) {
|
|
// merge the new comment into the item's newComments field, checking for duplicates
|
|
itemUpdateQuery(client, rootId, sort, (data) => mergeNewComment(data, newComment))
|
|
} else {
|
|
// if the comment is a reply, update the parent comment
|
|
// merge the new comment into the parent comment's newComments field, checking for duplicates
|
|
commentUpdateFragment(client, parentId, (data) => mergeNewComment(data, newComment))
|
|
}
|
|
}
|
|
}
|
|
|
|
// useLiveComments fetches new comments under an item (rootId), that arrives after the latest comment createdAt
|
|
// and inserts them into the newComment client field of their parent comment/post.
|
|
export default function useLiveComments (rootId, after, sort) {
|
|
const latestKey = `liveCommentsLatest:${rootId}`
|
|
const client = useApolloClient()
|
|
const [latest, setLatest] = useState(() => {
|
|
// if we're on the client, get the latest timestamp from session storage, otherwise use the passed after timestamp
|
|
if (typeof window !== 'undefined') {
|
|
return window.sessionStorage.getItem(latestKey) || after
|
|
}
|
|
return after
|
|
})
|
|
|
|
const { data } = useQuery(GET_NEW_COMMENTS, SSR
|
|
? {}
|
|
: {
|
|
pollInterval: POLL_INTERVAL,
|
|
// only get comments newer than the passed latest timestamp
|
|
variables: { rootId, after: latest },
|
|
nextFetchPolicy: 'cache-and-network'
|
|
})
|
|
|
|
useEffect(() => {
|
|
if (!data?.newComments?.comments?.length) return
|
|
|
|
// merge and cache new comments in their parent comment/post
|
|
cacheNewComments(client, rootId, data.newComments.comments, sort)
|
|
|
|
// update latest timestamp to the latest comment created at
|
|
// save it to session storage, to persist between client-side navigations
|
|
const newLatest = getLatestCommentCreatedAt(data.newComments.comments, latest)
|
|
setLatest(newLatest)
|
|
if (typeof window !== 'undefined') {
|
|
window.sessionStorage.setItem(latestKey, newLatest)
|
|
}
|
|
}, [data, client, rootId, sort, latest])
|
|
}
|